Adding a test for scale 0. #931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markstory
reviewed
Nov 1, 2025
Comment on lines
+2452
to
+2456
| $this->assertMatchesRegularExpression( | ||
| '/decimal\(65,0\)/i', | ||
| $createTableSql, | ||
| 'CREATE TABLE should contain DECIMAL(65,0) with scale=0 properly defined', | ||
| ); |
Member
There was a problem hiding this comment.
This feels like an assertion that may become brittle over time. We can try it and see how it goes. I think this kind of assertion is better done in cakephp/database as that is where the implementation lives.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if cakephp/phinx#2377 is also relevant for us
Seems like this is not an issue for 5.x+